Skip to content

Bump CLI Version to v2.12.0 for integration tests#1995

Merged
shati-patel merged 2 commits intomainfrom
github-action/bump-cli
Jan 20, 2023
Merged

Bump CLI Version to v2.12.0 for integration tests#1995
shati-patel merged 2 commits intomainfrom
github-action/bump-cli

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Bumps CLI version from v2.11.6 to v2.12.0

@github-actions github-actions bot requested a review from a team as a code owner January 20, 2023 17:15
@shati-patel shati-patel marked this pull request as draft January 20, 2023 17:18
@shati-patel shati-patel marked this pull request as ready for review January 20, 2023 17:18
v2.7.6, which was recommend for GHES 3.3, is now no longer supported. Manual removal for now, since we'll only need to do this once per quarter.
@shati-patel
Copy link
Copy Markdown
Contributor

Note: Additional commit deprecates version 2.7.6, since we only support the last 4 versions of GitHub Enterprise. 2.7.6 was used for GHES 3.3, which was discontinued on Jan 18th 2023:
image

(see the GitHub documentation)

@shati-patel shati-patel enabled auto-merge (squash) January 20, 2023 17:33
@shati-patel shati-patel merged commit 3ce6735 into main Jan 20, 2023
@shati-patel shati-patel deleted the github-action/bump-cli branch January 20, 2023 17:54
@aeisenberg
Copy link
Copy Markdown
Contributor

🎉 :fishsticks: 🎉

@aeisenberg
Copy link
Copy Markdown
Contributor

It's probably worth going through CliVersionConstraint and removing all old version constraints. That's a lot of code we can clean up.

@shati-patel
Copy link
Copy Markdown
Contributor

It's probably worth going through CliVersionConstraint and removing all old version constraints. That's a lot of code we can clean up.

Yes! I believe @koesie10 started looking at this: #1788

@koesie10
Copy link
Copy Markdown
Member

Unfortunately, I don't think we can actually remove version 2.7.6 yet. CodeQL CLI is the recommended version for GHES 3.4, which is supported until 2023-03-15.

@shati-patel
Copy link
Copy Markdown
Contributor

Unfortunately, I don't think we can actually remove version 2.7.6 yet. CodeQL CLI is the recommended version for GHES 3.4, which is supported until 2023-03-15.

Woooops, I assumed that sequential GHES versions would recommend sequential CLI versions, so I forgot to check GHES 3.4!

Thanks for pointing this out! We should still test against 2.7.6 in that case—re-added in #1999 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants